From beae6328c97bd87f64119c398a5c8a89047cfbfd Mon Sep 17 00:00:00 2001 From: Nabile Rahmani Date: Sat, 29 Feb 2020 18:32:52 +0100 Subject: [PATCH] - Corrected an instruction in the README. - Improved the GTK 2 theme to be more consistent with the GTK 3 one. Unfortunately, there's a couple unfixable issues due to the way the GTK devs did things. Sacrifices have to be made. Additionally, Qt apps will avoid some of these issues while introducing other inconsistencies, so that's always fun. Also, the assets.svg file had circles at the extremeties of the arrows for some weird reason. --- README.md | 2 +- common/gtk-2.0/dark/assets.svg | 214 +++--------------- common/gtk-2.0/dark/gtkrc | 9 +- common/gtk-2.0/main.rc | 38 ++-- .../menubar-toolbar/menubar-toolbar-dark.rc | 5 +- 5 files changed, 53 insertions(+), 215 deletions(-) diff --git a/README.md b/README.md index 6a9cb1b..c45e965 100644 --- a/README.md +++ b/README.md @@ -32,7 +32,7 @@ This should be compatible with GTK 2, GTK 3.20+, and GNOME Shell 3.18 through 3. - Since GTK 2 only looks at `~/.themes` for user theme files, you'll want to do either of these things: - `ln -s ~/.local/share/themes ~/.themes` to symlink the XDG themes folder to the user's folder. - - Rebuild with `./autogen.sh --prefix=$HOME/.themes` to move the theme's destination to where GTK 2 will check for files. + - Move `~/.local/share/themes/Arc-39` into the `~/.themes` folder. - The generated makefiles don't seem to watch for `.scss` changes to update the `.css` files when rebuilding. diff --git a/common/gtk-2.0/dark/assets.svg b/common/gtk-2.0/dark/assets.svg index e3befcc..ef5c890 100644 --- a/common/gtk-2.0/dark/assets.svg +++ b/common/gtk-2.0/dark/assets.svg @@ -996,7 +996,7 @@ height="21.999998" width="22" id="rect7903-2" - style="opacity:1;fill:#005666;fill-opacity:1;stroke:none;stroke-width:1;stroke-linecap:butt;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:0" /> + style="opacity:1;fill:#403e63;fill-opacity:1;stroke:none;stroke-width:1;stroke-linecap:butt;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:0" /> + style="display:inline;opacity:1;fill:none;fill-opacity:1;stroke:#00232b;stroke-width:0.99999994;stroke-linecap:butt;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1" /> + style="opacity:1;fill:#ff1177;fill-opacity:1;stroke:none;stroke-width:1;stroke-linecap:butt;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:0" /> - - + style="fill:#00cacf;fill-opacity:1" /> + style="fill:#00cacf;fill-opacity:1" /> + style="fill:#00cacf;fill-opacity:1" /> + style="fill:#00cacf;fill-opacity:1" /> - - - - - - - - @@ -4410,26 +4310,6 @@ d="m 183.78125,751 a 1.0001,1.0001 0 0 0 -0.5,1.71875 l 5,5 0.71875,0.6875 0.71875,-0.6875 5,-5 a 1.016466,1.016466 0 1 0 -1.4375,-1.4375 L 189,755.5625 184.71875,751.28125 A 1.0001,1.0001 0 0 0 183.78125,751 Z" id="path8393-9-9-5" style="color:#000000;font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;font-size:medium;line-height:normal;font-family:Sans;-inkscape-font-specification:Sans;text-indent:0;text-align:start;text-decoration:none;text-decoration-line:none;letter-spacing:normal;word-spacing:normal;text-transform:none;direction:ltr;block-progression:tb;writing-mode:lr-tb;baseline-shift:baseline;text-anchor:start;display:inline;overflow:visible;visibility:visible;fill:#0098a2;fill-opacity:1;stroke:none;stroke-width:2;marker:none;enable-background:accumulate" /> - - @@ -4628,26 +4508,6 @@ id="path8393-09-3-1" d="m 183.78125,751 a 1.0001,1.0001 0 0 0 -0.5,1.71875 l 5,5 0.71875,0.6875 0.71875,-0.6875 5,-5 a 1.016466,1.016466 0 1 0 -1.4375,-1.4375 L 189,755.5625 184.71875,751.28125 A 1.0001,1.0001 0 0 0 183.78125,751 Z" inkscape:connector-curvature="0" /> - - - - + style="color:#000000;font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;font-size:medium;line-height:normal;font-family:Sans;-inkscape-font-specification:Sans;text-indent:0;text-align:start;text-decoration:none;text-decoration-line:none;letter-spacing:normal;word-spacing:normal;text-transform:none;direction:ltr;block-progression:tb;writing-mode:lr-tb;baseline-shift:baseline;text-anchor:start;display:inline;overflow:visible;visibility:visible;fill:#00cacf;fill-opacity:1;stroke:none;stroke-width:2;marker:none;enable-background:accumulate" /> **" styl widget_class "***" style "notebook_combobox_entry" widget_class "****" style "combobox_entry" -# We also need to avoid changing fg color for the inactive notebook tab labels -widget_class "*." style "notebook_tab_label" - # GTK tooltips widget "gtk-tooltip*" style "tooltips" @@ -2345,5 +2339,7 @@ widget "xfwm4-tabwin*GtkButton*" style "xfwm- widget_class "*" style "text" widget_class "**" style "menu_text" widget_class "**" style "text" -widget_class "**" style "text" +widget_class "*." style "notebook_tab_label" # NOTE: Styles aren't additive, so the last one for a given class match overrides all the others. Care must be taken to properly order these matches, and inherit or redefine the properties of the overriden styles to get the correct visuals. A couple wrong things with this: firstly, GTK is using fg[ACTIVE] for *inactive* tabs, so naturally it looks wrong (thanks, geniuses). Secondly, you can't match ".